ONA Gateway <> Upstream Gateway Merge attempt #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking user permissions when requesting for data from the server.
… the Proxy server.
…r assignments for the User requesting the data from the server WIP
- Refactor Permission checker to be Generic - Update Spotless Check dependencies
- Implement Patient POST, PUT, DELETE
- Unit test for HTTP Verb GET permission checker - Unit test for HTTP Verb DELETE permission checker
- Add OpenSRPAccessDecision that pre-processes the request to add location, organization or team tags for data filtering during sync
- Implement PUT Permission Checker - Implement POST Permission Checker - Add unit tests for PUT and POST implementations
…r assignments for the User requesting the data from the server WIP
…r assignments for the User requesting the data from the server WIP
- Authorization Interceptor currently tightly coupled with Patient Finder, temp fix for custom Access Checker
- Permission Checker Implementation For POST Bundle - Add Unit tests
…r assignments for the User requesting the data from the server
- Add random filter to users without location, team or organisation assignments - Disable modification of the complete URL and request path in ServletRequestDetails - Add tests for OpenSRPSyncAccessDecision - Fix tags
…ta-filtering-user-assignments
- Formatting
…ss-checker' into issue/1662-data-filtering-user-assignments-new-branch
bashir2
reviewed
Sep 14, 2023
bashir2
reviewed
Sep 14, 2023
server/src/main/java/com/google/fhir/gateway/BearerAuthorizationInterceptor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/TokenVerifier.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/ResourceFinderImp.java
Outdated
Show resolved
Hide resolved
|
BTW, please also [digitally] sign the Google CLA as well. |
ndegwamartin
force-pushed
the
2213-prac-details
branch
from
19bf54c
to
09daceb
Compare
bashir2
reviewed
Sep 29, 2023
server/src/main/java/com/google/fhir/gateway/AllowedQueriesConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/AllowedQueriesChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/google/fhir/gateway/AllowedQueriesChecker.java
Outdated
Show resolved
Hide resolved
bashir2
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks for the changes @ndegwamartin and @rehammuzzamil I think this is almost ready. There is just one redundant if block which I think can be removed. Then we can merge this and make a release.
server/src/main/java/com/google/fhir/gateway/AllowedQueriesChecker.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master